Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "mp4-created" option to set video-time-start/end using mp4 metadata #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jburnhams
Copy link
Contributor

Contributor Checklist

  • Review Contribution Guidelines
  • Agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the GNU Licence
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by maintainers if required.
  • Unit tests created/updated (under tests) to verify logic, and approval tests for UI Widgets
  • Update Examples - Under build-scripts/examples, and regenerate examples docs if required ( make doc-examples )
  • Ensure that tests pass locally - this can be tricky for approval tests with maps or text though.
  • Check that pre-release tests work ( make test-distribution )

@jburnhams
Copy link
Contributor Author

jburnhams commented Mar 5, 2024

I've got a mismatch from timezone / BST - investigating....
Ah no, my mp4 file has the metadata timestamp as UTC when it should be BST. I'll hack it for me but don't think anything needs changing here for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant