Skip to content

Commit

Permalink
Fix validation message to say ControllerRing
Browse files Browse the repository at this point in the history
  • Loading branch information
timebertt committed Jan 29, 2025
1 parent 6258ed9 commit c55ed42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion config/crds/sharding.timebertt.dev_controllerrings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ spec:
type: object
type: object
x-kubernetes-validations:
- message: ClusterRing name must not be longer than 63 characters
- message: ControllerRing name must not be longer than 63 characters
rule: size(self.metadata.name) <= 63
served: true
storage: true
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/sharding/v1alpha1/types_controllerring.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
//+kubebuilder:printcolumn:name="Available",type=string,JSONPath=`.status.availableShards`
//+kubebuilder:printcolumn:name="Shards",type=string,JSONPath=`.status.shards`
//+kubebuilder:printcolumn:name="Age",type="date",JSONPath=`.metadata.creationTimestamp`
//+kubebuilder:validation:XValidation:rule="size(self.metadata.name) <= 63",message="ClusterRing name must not be longer than 63 characters"
//+kubebuilder:validation:XValidation:rule="size(self.metadata.name) <= 63",message="ControllerRing name must not be longer than 63 characters"

// ControllerRing declares a virtual ring of sharded controller instances. Objects of the specified resources are
// distributed across shards of this ring. Objects in all namespaces are considered unless a namespaceSelector is
Expand Down

0 comments on commit c55ed42

Please sign in to comment.