Implement external sharder controller #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This help in debugging when observing individual watch events.
The previous approach was buggy and removed all data/spec via its patches. Constructing individual patch operations is more precise and way more performant than marshalling twice for calculating the patch.
We don't want to rely on the state label being maintained corretly in the sharder webhook or controller. Determining the state directly based on the local clock is favorable as it makes it easier to trigger in predicates when the controller will actually act on changed lease data. This increases the rate of ring calculations again, but is more consistent and correct. This was a premature optimization. We can still optimize ring calculations again when it becomes real problem.
timebertt
force-pushed
the
external-sharder-controller
branch
from
f1f12c8 to
b4a8fb9
Compare
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 3 of implementing the new external sharding approach after #30.
This PR tackles:
namespaceSelectortoClusterRings: this is used in the webhook config but also for filtering objects in the sharder controllerIt performs a few smaller improvements like handling dry-run in the sharder webhook, and minimizing reconciliations of dummy shard for easier debugging.
webhosting-operator will be adapted to the external sharder implementation in the next PR.