fix: handle 'null' value in chunking 'chunk_column' #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
approved these changes
Jan 6, 2025
Askir
approved these changes
Jan 6, 2025
JamesGuthrie
force-pushed
the
jg/handle-null-contents-column
branch
from
8a7f1d0 to
030bca0
Compare
The chunking configuration takes a 'chunk_column' parameter, which determines which column of the source row is chunked. This commit treats a null entry as being equivalent to the empty string, and no embeddings are generated.
JamesGuthrie
force-pushed
the
jg/handle-null-contents-column
branch
from
030bca0 to
ac8f340
Compare
Honestly I don't remember. I've replaced the broken ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunking configuration takes a 'chunk_column' parameter, which determines which column of the source row is chunked.
This commit treats a null entry as being equivalent to the empty string, and no embeddings are generated.
Fixes #334