Read replicas #132
Merged
Read replicas #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronblevy
force-pushed
the
aaron/read_replicas
branch
4 times, most recently
from
e216948 to
3e5d746
Compare
aaronblevy
commented
Jan 5, 2024
| } | ||
|
|
||
| type ForkConfig struct { | ||
| ProjectID string `json:"projectID"` |
There was a problem hiding this comment.
the input for ForkConfig when creating a service uses projectID, while the types for ForkSpec use projectId so I think I need different structs here.
RobAtticus
approved these changes
Jan 5, 2024
aaronblevy
force-pushed
the
aaron/read_replicas
branch
from
3e5d746 to
a081780
Compare
Khyme
approved these changes
Jan 8, 2024
|
Looks like there's a bug where you can create a read replica off a read replica that I need to fix before merging |
|
I also forgot to add validation on Update(), added those checks and some tests 😄. |
aaronblevy
force-pushed
the
aaron/read_replicas
branch
from
d15d187 to
1a05d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow managing a read replica using Terraform. A read replica is specified as a resource with the attribute
read_replica_sourceset.The provider applies some validation steps. The main one is to prevent multiple read replicas for the same service. If a user specifies multiple read replicas with the same source, Terraform will attempt to create these in parallel (unless the user specifies a parallelism of one). To get around this, we use a global read replica lock to synchronize the process of creating a read replica. Before we create the replica, we check if there is an existing read replica for a service. To do this, we fetch all the services the project and check if any of the fork configurations specify the same source.
This can be later optimized with service level mutexes. Since that would complicates the logic further, it's omitted in this PR.