fix: updates for using pg_textsearch for keyword search #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
changed the title
Signed-off-by: Matthew Peveler <[email protected]>
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
force-pushed
the
mpeveler/feat-text-search
branch
from
4dcaa4b to
5193d30
Compare
Signed-off-by: Matthew Peveler <[email protected]>
Signed-off-by: Matthew Peveler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR does:
Adds a migration for enabling theSplit off into feat: add migration for pg_textsearch #33 where that can be merged later once extension is generally available.pg_textsearchextension along with creating the necessary index ontimescale_chunks.content.to_bm25query)pg_textsearchwhere when an index is added to a table in non-default schema, then inserts will fail. The fix is to remove the index as we do the ingest into the temporary table, and then re-add it after we're done. This change should be removed in a follow-up PR though.By default the migration will be skipped as it can only be enabled in tiger cloud environments.