Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Binary build #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Binary build #12

wants to merge 4 commits into from

Conversation

duk3luk3
Copy link

It is way too late and I have way too much of a headache and not nearly enough clue about Github actions but here's a quick binary build.

Why: To make this tool more accessible to people who might not have a python interpreter handy - https://chaos.social/@afelia/109324760852451263

Entirely untested because I don't have a twitter archive (yet)

Future goals:

  • Automatically push a release on tags?
  • Make it pass smart screen on windows, if such a thing is possible

@duk3luk3
Copy link
Author

This may be a drive-by PR, we'll have to see when my twitter archive comes in and how I feel over the weekend.

@timhutton
Copy link
Owner

Interesting, thanks @duk3luk3. I'm wary that this might be overcomplicating things.

I agree it would be nice if there was no command-line to run. I was thinking a nicer solution might be a web page where a user can open their twitter zip file and it produces a replacement. (Should be possible to be done all client-side, with no uploading or downloading needed.)

@duk3luk3
Copy link
Author

Yeah, I spent about 15 minutes looking into Brython for the web solution and it has no documentation for working with uploaded files. I had a look on StackOverflow which has some results (for JS) suggesting that it's possible.

It's also extremely annoying to work around server / cors issues when developing Brython as someone who tried it out on a whim in a severely sleep-deprived state.

There is a trust/privacy issue with a web solution, but of course that is still present with a "desktop" app, just on a slightly different angle.

@duk3luk3
Copy link
Author

Can you say more about where your thoughts about "overcomplicating things" are?

@timhutton
Copy link
Owner

@duk3luk3 Re 'overcomplicating': I was just thinking about what the instructions would need to be, for each platform. It might end up being more complicated to explain how to download and run an executable. Don't executables on macOS need to be signed correctly? What about Linuxen other than Ubuntu?

A web approach wouldn't be a good fit for the new script for downloading images (#28).

I don't want you to lose any sleep! These things can wait. :)

@timhutton
Copy link
Owner

@duk3luk3 I've thought of another reason for preferring a script: it makes it easier for the user to make changes. Even if they don't know python they can open the file and make small changes such as the output filenames. It empowers users to have the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants