-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #7
Comments
Some suggestion for pure javascript Hook up eslint and prettier and unicorn. Unicorn has sane defaults for modern javascript. Add
Everything else should be imported. FYI probot blocks you from switching to ESM. So stick with commonjs due to: probot/pino#188 |
Sure can have a look at unicorn. Prettier is already in place here. The typings already seem to work quite well but can add if it helps more. and yeah will do eslint. I have the start of some jest tests locally but didn't get much time yesterday on it. Thanks for the suggestions |
Link to unicorn eslint plugin at least: https://github.com/sindresorhus/eslint-plugin-unicorn |
:) I found it in your PR, but that would've helped, it didn't come up on google (without adding eslint to search) |
Great stuff 👏 |
No description provided.
The text was updated successfully, but these errors were encountered: