Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and allow space separator for reviewers #41

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Add tests and allow space separator for reviewers #41

merged 3 commits into from
Jul 25, 2022

Conversation

timja
Copy link
Owner

@timja timja commented Jul 22, 2022 •
edited
Loading

Fixes #7
Fixes #35

hervelemeur
hervelemeur reviewed Jul 23, 2022
View reviewed changes
app/matchers.js Outdated Show resolved Hide resolved
@timja timja marked this pull request as ready for review July 25, 2022 08:04
@timja timja merged commit d13cf9c into main Jul 25, 2022
@timja timja deleted the add-tests branch July 25, 2022 08:07
@timja timja added the tests label Jul 25, 2022
@timja timja changed the title Add tests Add tests and allow space separator for reviewers Jul 25, 2022
@timja timja added the enhancement New feature or request label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hervelemeur hervelemeur hervelemeur left review comments

Assignees
No one assigned
Labels
enhancement New feature or request tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple reviewers should be space separation. Add tests
2 participants
@timja @hervelemeur