Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing 'PendingIntent.FLAG_MUTABLE' and fixed gradle #8

Closed
wants to merge 14 commits into from

Conversation

fquirin
Copy link

@fquirin fquirin commented Jul 17, 2022

  • Added missing 'PendingIntent.FLAG_MUTABLE' to Notification and Builder Java files for Android
  • Fixed gradle build file to use 'implementation' and updated 'appShortcutBadgerVersion'

@bhandaribhumin
Copy link

@timkellypa When will you merge this?

@123dma
Copy link

123dma commented Oct 31, 2022

Hello, I added these changes in an internal version that I use here and although the error no longer occurs I was only able to receive the scheduled notification after adding the permission in the App manifest.

<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />

@fquirin
Copy link
Author

fquirin commented Nov 1, 2022

yes, I think that is required now. I've always had it in my Cordova config, so I might not have noticed any changes. I'm not sure how to add it to the plugin automatically though? Any suggestions?

@GitToTheHub
Copy link

@fquirin
Thank you, for adding the fixes here!
I saw some repository-replacements from the original"katzer"-repository to your repository or to the "bhandaribhumin"-repository in the files "CHANGELOG.md", "package.json" and "plugin.xml". Are they necessary?

@GitToTheHub
Copy link

@fquirin
It would be great, if you could create a merge-branch, which would contain the changes :)

@fquirin
Copy link
Author

fquirin commented Dec 27, 2022

I just realized that the latest changes accidentally ended up in this old PR when I updated my repository 🙈
The original plan was to create a new branch to clean up the README, package.json, etc.., revert the comments and changes that where only meant for the fork and then push everything to the original 'katzer' repository.

Here is a bit more info about the changes: katzer#1990

Maybe I'll find some time to do this in the next days, but it is not really at the top of my to-do list ^^.

@fquirin
Copy link
Author

fquirin commented Dec 27, 2022

I decided to quickly put something together ^^:

katzer#2000 and #10

I'm going to close this one in favor of a new PR.

@fquirin fquirin closed this Dec 27, 2022
@GitToTheHub
Copy link

Cool, thank you for your work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants