-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing 'PendingIntent.FLAG_MUTABLE' and fixed gradle #8
Conversation
fquirin
commented
Jul 17, 2022
- Added missing 'PendingIntent.FLAG_MUTABLE' to Notification and Builder Java files for Android
- Fixed gradle build file to use 'implementation' and updated 'appShortcutBadgerVersion'
... updated 'appShortcutBadgerVersion'
@timkellypa When will you merge this? |
Hello, I added these changes in an internal version that I use here and although the error no longer occurs I was only able to receive the scheduled notification after adding the permission in the App manifest.
|
yes, I think that is required now. I've always had it in my Cordova config, so I might not have noticed any changes. I'm not sure how to add it to the plugin automatically though? Any suggestions? |
@fquirin |
@fquirin |
I just realized that the latest changes accidentally ended up in this old PR when I updated my repository 🙈 Here is a bit more info about the changes: katzer#1990 Maybe I'll find some time to do this in the next days, but it is not really at the top of my to-do list ^^. |
I decided to quickly put something together ^^: katzer#2000 and #10 I'm going to close this one in favor of a new PR. |
Cool, thank you for your work! :) |