-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts.add hover styling #1078
Open
trillium
wants to merge
19
commits into
timlrx:main
Choose a base branch
from
trillium:ts.add_hover_styling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ts.add hover styling #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create ListLayouBase component - Adapt expected behavior from Main version of file to exist alongside WithTags version
@trillium is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I wanted to have a bit more visual feedback when the user hovered on blog posts. I'm using these changes on my personal blog and though the template might benefit from them as well.
Changes Overview
ListLayoutWithTags.tsx
to extractPagination
and the base configuration of list layoutPagination
component from code withinListLayoutWithTags.tsx
ListLayoutBase
component from a combination of code fromListLayoutWithTags.tsx
andMain.tsx
ListLayoutBase
to add hover effect on each blog entryTag.tsx
to be displayed under each blog postVisual Changes
View a deployed version of the changes here