New disableRestore setting #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvd0x2a
force-pushed
the
disable-restore
branch
from
f70e937 to
4684f74
Compare
|
|
### Added - New setting `disableRestore` that allows the restore functionality to be disabled. For example, enables Craft admins to disable restore on one environment, like production, to avoid accidental overwrites.
tvd0x2a
force-pushed
the
disable-restore
branch
from
0a824e0 to
4214e1f
Compare
tvd0x2a
commented
Mar 19, 2024
| $remoteSync = Craft::$app->plugins->getPlugin("remote-sync"); | ||
| $settings = $remoteSync->getSettings(); | ||
| if (!property_exists($settings, 'disableRestore')) { | ||
| Craft::$app->getPlugins()->savePluginSettings($remoteSync, [ |
There was a problem hiding this comment.
I'm new to craft plugin development... is this needed?
|
Thanks @tvd0x2a for the work on this. Let me review. |
|
Hi @timmyomahony, when do you think you'll have a chance to review? Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
disableRestorethat allows the restore functionality to be disabled. For example, enables Craft admins to disable restore on one environment, like production, to avoid accidental overwrites.