Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #89 for example Kubernetes yaml.
Remaining decisions:
Which value to pick. Are
.glucoseMeasurement
and.glucoseItem
equivalent? Or maybe it's better to use the newest.graphData
entry instead?I haven't had the chance to test with no sensor values yet. What should be exported then? If using Prometheus alerts, exporting zeroes is impractical. Alert definitions should be as simple as possible, for example
glucose_value < 3.5
.Maybe
glucose_low=0
,glucose_high=0
and not exportingglucose_value
orglucose_trend
? Prometheus can alert on absent metrics.I'll add unit tests for the strategy we pick.
What do we know about the
TrendArrow
value (present in glucoseItem but not in graphData)? It's constantly been3
since I started testing.What to do in SINGLE_SHOT mode with prometheus enabled?