Skip to content

Commit

Permalink
Fix typing
Browse files Browse the repository at this point in the history
  • Loading branch information
timotk committed Jul 29, 2023
1 parent 10bc6d5 commit c7d95e4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion tests/test_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest

from tests.mocks import mock_get
from tweakers.models import Comment
from tweakers.comment import Comment
from tweakers.topic import Topic
from tweakers.user import User

Expand Down
8 changes: 4 additions & 4 deletions tweakers/article.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import datetime
from typing import Any, Optional
from typing import Any, List, Optional

from pydantic import BaseModel

from tweakers import parsers
from tweakers.models import Comment
from tweakers.comment import Comment
from tweakers.utils import get


Expand All @@ -13,12 +13,12 @@ class Article(BaseModel):
title: str
comment_count: int
published_at: datetime.datetime
_comments: Optional[list[Comment]] = None
_comments: Optional[List[Comment]] = None
_html: Optional[Any] = None
_text: Optional[str] = None

@property
def comments(self) -> list[Comment]:
def comments(self) -> List[Comment]:
# TODO: Add pagination of comments
if self._comments is None:
self._comments = [Comment(**d) for d in parsers.article_comments(self.html)]
Expand Down
2 changes: 1 addition & 1 deletion tweakers/topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
class Topic(BaseModel):
url: str
title: Optional[str] = None
author: Optional[Union[User, list[User]]] = None
author: Optional[Union[User, List[User]]] = None
last_reply: Optional[datetime] = None
comment_count: Optional[int] = None
_html: Optional[Any] = None
Expand Down

0 comments on commit c7d95e4

Please sign in to comment.