Update groups.groovy

[DavidtKate]

Group JSON files can now be read in as:

{
	"groups": [
		{
			"name": "<GROUPNAME>",
			"discordID": "<DISCORD_ID>",
			"swarmID": ["<SWARM_ID>", "<SWARM_ID>"],
			"type": "<GROUPTYPE>"
		}
	]
}

[DavidtKate]

swarm.groovy also requires changes to GetGroupMembers

[timrademaker]

I suppose the , at the end of the mention string might not be needed at all if this now tags a single Discord ID rather than a list of them.

[DavidtKate]

Yea

[timrademaker]

Is it possible to break out of this loop prematurely?

[DavidtKate]

Breaking out of for-each loops in Groovy is illegal ([https://stackoverflow.com/questions/3049790/can-you-break-from-a-groovy-each-closure]). However using find ([https://www.tutorialspoint.com/groovy/groovy_find.htm]) we can break out of the loop prematurely using return true.

[timrademaker]

Doesn't loadGroups already parse the groups?

If you're passing the full group json into this function, maybe split loadGroups up into loadGroupsFromFile and loadGroupsFromString, or have loadGroups return the json string rather than a parsed version. (This would also mean that saveGroups shouldn't convert the groups to json, as they would already be in that format).

[DavidtKate]

Oh yeah missed that function. I suppose we can remove loadGroups (and pass file as string as argument) or convert loadGroups to just reading in the file and parsing it using JsonSlurper and return the JsonObject.