-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vagrant to demonstrate install #57
base: master
Are you sure you want to change the base?
Conversation
Can you fix the spelling / punctuation in the commit messages? You can use |
@@ -1 +0,0 @@ | |||
README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this symlink?
…t package install postinst.
I think I cleaned up all the things you mentioned. |
# for when vagrant skips the interactive prompting. | ||
$(ACTIVATE) && python manage.py syncdb --noinput | ||
# $(ACTIVATE) && python manage.py createsuperuser || true | ||
$(ACTIVATE) && python manage.py runserver & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runserver line should be under the serve target.
@@ -45,7 +45,8 @@ third_party: | |||
|
|||
src/pip-delete-this-directory.txt: requirements.txt | |||
$(ACTIVATE) && pip install -r requirements.txt | |||
$(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt | |||
# $(ACTIVATE) && [ -f private/requirements.txt ] && pip install -r private/requirements.txt | |||
$(ACTIVATE) && pip install -r private/requirements.txt || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still wrong. The line you are removing is correct.
Hi @CarlFK This pull request no longer merges. Can you please rebase onto the latest and then I'll try merging it. Tim |
Reopening pull request because it commits were never merged. Need to figure out if we should remove the commits from @CarlFK repo or do something more. |
@CarlFK poke? |
I did this so GSOC students could verify that the install process works. I On Sat, Jan 31, 2015 at 8:58 AM, Tim Ansell [email protected]
Carl K |
There is another set of GSoC students only a month or two away from now, There were also some other changes in here you made to make the install On 1 February 2015 at 02:07, Carl Karsten [email protected] wrote:
|
I suspect the install is more complicated than it needs to be. There are 2 cases:
Those don't need to be the same script. given that, I think we need to refactor the install process. Last year I You / apps should have a good idea what the requirements are. put them in On Sat, Jan 31, 2015 at 9:41 AM, timsvideo-portable <
Carl K |
No description provided.