Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip the CA certificate Validation. This fixes #6 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaomatossilva
Copy link

No description provided.

@rolftimmermans
Copy link
Contributor

I'm not sure about this. Shouldn't it be a compile time flag? Very few API users will create a Client directly.

In any case omitting ServerCertificateCustomValidationCallback does not mean that the certificate is not validated, it means that it's validated with the default roots, not the roots supplied in src/Tinify/data/cacert.pem.

@joaomatossilva
Copy link
Author

In order to make it a compile time flag, you would need to create two diferent libraries. One with and another one without. I got the impression this was going just to be a fallback while Microsoft has issues with the just supporting the OpenSsl.

By ommitting the ServerCertificateCustomValidationCallback I was just falling back to the originalo behaviour of the HttpClient.
Do you mean we should skip validation at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants