Skip to content

Commit

Permalink
Merge pull request #102 from jacobweinstock/update-perms
Browse files Browse the repository at this point in the history
Remove list permission on secrets for Rufio:

## Description

<!--- Please describe what this PR is going to change -->
This is unneeded and a potential security issue.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: #96 

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
jacobweinstock authored Jun 10, 2024
2 parents 2fb7daf + 99265ff commit f64eb25
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tinkerbell/rufio/templates/cluster-role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ rules:
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- bmc.tinkerbell.org
Expand Down

0 comments on commit f64eb25

Please sign in to comment.