Skip to content

Commit

Permalink
stack: introduce hook.downloadEnabled boolean to include/exclude hook…
Browse files Browse the repository at this point in the history
… download job

- sometimes we don't want to download the default hook binaries
- this is separate from stack.hook.enabled, which controls the hostPath etc

Signed-off-by: Ricardo Pardini <[email protected]>
  • Loading branch information
rpardini committed Mar 23, 2024
1 parent dcdac9b commit fd93cb3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tinkerbell/stack/templates/hook.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if .Values.stack.hook.enabled }}
{{- if .Values.stack.hook.downloadEnabled }}
---
apiVersion: v1
kind: ConfigMap
Expand Down Expand Up @@ -39,7 +40,7 @@ spec:
containers:
- name: download-hook
image: {{ .Values.stack.hook.image }}
command: ["/script/entrypoint.sh"]
command: [ "/script/entrypoint.sh" ]
volumeMounts:
- mountPath: /output
name: hook-artifacts
Expand All @@ -55,4 +56,5 @@ spec:
configMap:
defaultMode: 0700
name: download-hook
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions tinkerbell/stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ stack:
# downloadURL only works with the > 0.8.1 Hook release because
# previous Hook versions didn't provide a checksum file.
downloadURL: https://github.com/tinkerbell/hook/releases/download/latest
downloadEnabled: true # Set to false if you somehow download Hook manually; if set to True will include a download Job
kubevip:
enabled: true
name: kube-vip
Expand Down

0 comments on commit fd93cb3

Please sign in to comment.