Tinkerbell chart improvements

[ahreehong]

Description

This PR adds the following:

• Templates out the args for the rufio deployment so that users can provide other rufio flags if desired.
• Updates "urlJoiner" to not add a colon to the url if no port is provided
• Allows kubevip prometheus_server to be set to override the default address

Why is this needed

These changes allow the tinkerbell chart to be more customizable for various use cases

How Has This Been Tested?

Tested manually with EKS-Anywhere

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
• provided instructions on how to upgrade

[jacobweinstock]

Curious, is there a known use case for needing this? Kubernetes has some general guidance to not use hostPort. ref

[jacobweinstock]

We should open up env vars generically here. This way we dont need to keep up to date on all possible options as the come and go. We do this in Smee:

charts/tinkerbell/smee/templates/deployment.yaml

Line 67 in e34a640

{{- range .Values.additionalEnv }}

You don't have to follow this naming convention (additionalEnv) though. It could just something like .Values.env or similar.

[ahreehong]

Yeah that sounds like a great idea. will update the PR shortly!

[jacobweinstock]

mind adding the code comment for the format of the values in this array? see the Smee example:

charts/tinkerbell/smee/values.yaml

Line 124 in 43a6c2c

# Additional environment variables to pass to the smee container. Each entry is expected to have a

[jacobweinstock]

this might need to hardcode --leader-elect and then additional args can be added. In its current state if the use modifies the rufio args from the stack they'll need to be aware that they will also need to supply --leader-elect. Smee handles this with an additionalArgs

charts/tinkerbell/smee/values.yaml

Line 119 in 8ca2213

additionalArgs: []