stack: directly expose smee when relay is disabled #116
Conversation
| {{- if .Values.stack.lbClass }} | ||
| loadBalancerClass: {{ .Values.stack.lbClass }} | ||
| {{- end }} | ||
| loadBalancerIP: {{ .Values.stack.loadBalancerIP }} |
There was a problem hiding this comment.
this looks to be the same value as the stack service object. I dont think 1 load balancer IP for 2 services is going to work.
There was a problem hiding this comment.
I already tried and it can work as the ports are different. But I was considering whether we should use hostNetwork for smee in this situation or not?
There was a problem hiding this comment.
@jacobweinstock Can you take a look again? I guess this one makes more sense.
| @@ -183,9 +184,12 @@ spec: | |||
| - port: {{ .Values.smee.syslog.port }} | |||
| protocol: UDP | |||
| name: {{ .Values.smee.syslog.name }} | |||
| {{- end }} | |||
| {{- if .Values.stack.relay.enabled }} | |||
There was a problem hiding this comment.
port 67 for Smee is used for unicast traffic. The relay container is used for broadcast traffic. The relay being enabled should not gate this port.
There was a problem hiding this comment.
It's for when the loadbalancer IP is the same as host IP (single node installation). Also this would be unnecessary when relay is disabled.
Do you have any reason why to keep it when relay is disabled?
Or maybe I misunderstood the purpose of port 67 exposed by the lb? isn't that pointing to the dhrelay in stack pod?
There was a problem hiding this comment.
It points at Smee not the relay. It's for unicast DHCP messages like when a DHCP relay from a switch or router points at Smee.
There was a problem hiding this comment.
But the selector is pointing to the stack:
selector:
{{- with .Values.stack.selector }}
{{- toYaml . | nindent 4 }}
{{- end }}and the stack is maintaining relay for port 67:
- name: {{ .Values.stack.relay.name }}
image: {{ .Values.stack.relay.image }}
args: ["-m", "{{ .Values.stack.relay.presentGiaddrAction }}", "-c", "{{ .Values.stack.relay.maxHopCount }}", "-id", "{{ $dhcpInterfaceName }}", "-iu", "eth0", "-U", "eth0", "smee.{{ .Release.Namespace }}.svc.{{ .Values.stack.clusterDomain }}."]
ports:
- containerPort: 67
protocol: UDP
name: DHCPAm I mistaken?
Avoid conflicts when smee is using hostNetwork and loadbalancer IP is the same as hostNetwork. Signed-off-by: Seena Fallah <[email protected]>
jacobweinstock
force-pushed
the
smee-dhcp
branch
from
3b1daa4
to
e824bfc
Compare
Description
If dhrelay is disabled, smee needs to be exposed directly via loadbalancer instead.
Why is this needed
Currently, if dhrelay is disabled, smee can't be accessed.