main.go fixes and improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So first group is standard library as it was previously, then we have external imports and module-local imports as third group. Signed-off-by: Mateusz Gozdek <[email protected]>
If description exeeds line length limits of lll linter, then move it to another line. Signed-off-by: Mateusz Gozdek <[email protected]>
Signed-off-by: Mateusz Gozdek <[email protected]>
So only pointer fields must be declared independently. Signed-off-by: Mateusz Gozdek <[email protected]>
Logger complains about odd number of arguments given to Error function. Signed-off-by: Mateusz Gozdek <[email protected]>
To make main() shorter. Signed-off-by: Mateusz Gozdek <[email protected]>
Signed-off-by: Mateusz Gozdek <[email protected]>
As klog is a standard logger for Kubernetes controllers which should be used. Signed-off-by: Mateusz Gozdek <[email protected]>
To again make main() shorter and to give this piece of code a name. Signed-off-by: Mateusz Gozdek <[email protected]>
detiber
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spotted some growing complexity in #8 so I decided to refactor things a bit to make
main()shorter. Also #8 implicitly changes logger from zap to klog, so did that here explicitly instead.Why is this needed
Fixes: #23
How Has This Been Tested?
Build and run binary locally.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: