Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabling of DHCP per interface: #1015

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jacobweinstock
Copy link
Member

Description

Adds flexibility on a per hardware basis that already exists in Smee at a global level.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Adds flexibility on a per hardware basis that
already exists in Smee at a global level.

Signed-off-by: Jacob Weinstock <[email protected]>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.39%. Comparing base (ae9786e) to head (b12b016).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   31.39%   31.39%           
=======================================
  Files          75       75           
  Lines        4686     4686           
=======================================
  Hits         1471     1471           
  Misses       3120     3120           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock jacobweinstock merged commit be32b6b into tinkerbell:main Oct 23, 2024
12 checks passed
@jacobweinstock jacobweinstock deleted the disable-dhcp branch October 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant