Add support to create aliases for base24 themes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbode
requested review from
belak and
mattdavis90
and removed request for
a team
joshbode
force-pushed
the
joshbode/alias-24-themes
branch
from
1d22ec5 to
cecb734
Compare
joshbode
commented
Oct 13, 2024
| @@ -110,10 +111,6 @@ set_theme() | |||
| done | |||
| unset hook | |||
| fi | |||
|
|
|||
| unset theme_name | |||
There was a problem hiding this comment.
these variables are already local to the function
| @@ -58,7 +58,8 @@ set_theme() | |||
| { | |||
| local theme_name="$1" | |||
| local force_load="$2" | |||
| local script_path="$BASE16_SHELL_PATH/scripts/base16-$theme_name.sh" | |||
| local n="${3-16}" | |||
There was a problem hiding this comment.
the least disruptive option I could think of was to just add another argument. Alternatively the n could have been part of the theme name, but that would potentially break existing usage of set_theme since the theme name argument is stripped of the base{n}- prefix
| theme_name=${script_name#"base${n}-"} # eg: solarized-light | ||
| function_name="base${n}_${theme_name}" | ||
|
|
||
| alias ${function_name}="set_theme ${theme_name} '' ${n}" |
There was a problem hiding this comment.
the second argument is an empty string to not affect the force argument of set_theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.