Fix memory leak by canceling timers in $destroy

tinydesk · Jul 29, 2016 · 29f653f · 29f653f
1 parent c3913d6
commit 29f653f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/dist/tileview.js b/dist/tileview.js
@@ -128,6 +128,16 @@
                     angular.element($window).on('resize', onResize);
                     scope.$on('$destroy', function () {
                         angular.element($window).off('resize', onResize);
+                        // unregister all timers:
+                        if (resizeTimeout !== undefined) {
+                            $timeout.cancel(resizeTimeout);
+                        }
+                        if (scrollEndTimeout !== undefined) {
+                            $timeout.cancel(scrollEndTimeout);
+                        }
+                        if (debounceTimeout !== undefined) {
+                            $timeout.cancel(debounceTimeout);
+                        }
                         removeAll();
                     });
                     function removeElement(el) {

diff --git a/src/tileview.ts b/src/tileview.ts
@@ -146,6 +146,18 @@ declare const angular: any;
 
         scope.$on('$destroy', function () {
           angular.element($window).off('resize', onResize);
+
+          // unregister all timers:
+          if (resizeTimeout !== undefined) {
+            $timeout.cancel(resizeTimeout);
+          }
+          if (scrollEndTimeout !== undefined) {
+            $timeout.cancel(scrollEndTimeout);
+          }
+          if (debounceTimeout !== undefined) {
+            $timeout.cancel(debounceTimeout);
+          }
+
           removeAll();
         });