Fix memory leak when removing rows

tinydesk · Jul 26, 2016 · 83c8afe · 83c8afe
1 parent 1642783
commit 83c8afe
Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/dist/tileview.js b/dist/tileview.js
@@ -218,8 +218,15 @@
                         itemContainer.append(row);
                         return row;
                     }
+                    function clearRow(row) {
+                        while (row.children().length > 0) {
+                            removeElementFromRow(row);
+                        }
+                    }
                     function removeRow() {
-                        itemContainer.children().eq(-1).remove();
+                        var row = itemContainer.children().eq(-1);
+                        clearRow(row);
+                        row.remove();
                     }
                     function addElementToRow(row) {
                         linkFunction(scope.$parent.$new(), function (clonedElement) {

diff --git a/src/tileview.ts b/src/tileview.ts
@@ -250,8 +250,16 @@ declare const angular: any;
           return row;
         }
 
+        function clearRow(row) {
+          while (row.children().length > 0) {
+            removeElementFromRow(row);
+          }
+        }
+
         function removeRow() {
-          itemContainer.children().eq(-1).remove();
+          const row = itemContainer.children().eq(-1);
+          clearRow(row);
+          row.remove();
         }
 
         function addElementToRow(row) {