fix: corrections for HCI GAP Advertiser #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysoldak
reviewed
Jan 9, 2025
ysoldak
reviewed
Jan 9, 2025
deadprogram
force-pushed
the
fix-hci-gap-adv
branch
from
ec67475 to
0fa0605
Compare
…gTypeNonConnInd Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
fix-hci-gap-adv
branch
from
0fa0605 to
9f7506c
Compare
|
Rebased against |
|
Note that in a future PR I will replace the entire HCI GAP implementation with the one in |
ysoldak
approved these changes
Jan 9, 2025
|
Thanks for review and feedback @ysoldak now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 corrections for HCI GAP Advertiser.
The first one is to not send the ADFlags when acting as a beacon to save bytes. Needed by FindMy manufacturer data.
The second is to set a more reasonable default value for HCI Interval, based on https://developer.apple.com/accessories/Accessory-Design-Guidelines.pdf as we do in other parts of the code.