Fix for #4678: top-level 'make lint' wasn't working #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The revive command seems to have had a syntax error in the file input glob. It appears to have been broken in a way that did not result in a return code being set. This change uses 'find' to build the input to the linter. Note that it is expected to fail the CI script, because it is uncovering some existing lint issues that were not being caught.
b0ch3nski
reviewed
Jan 3, 2025
GNUmakefile
Outdated
| @@ -1000,14 +1000,18 @@ endif | |||
| tools: | |||
| cd internal/tools && go generate -tags tools ./ | |||
|
|
|||
| LINTFILESCMD=find src/os/ src/reflect/ -type f -name '*.go' | |||
There was a problem hiding this comment.
How about changing this variable to contain a list of directories to scan? That would be easier to maintain/adjust/expand in future.
There was a problem hiding this comment.
@b0ch3nski Similar to this? 7190e01
b0ch3nski
approved these changes
Jan 13, 2025
|
This PR seems like a good thing, but then suddenly will require a followup to fix all of the issues it raises, if I am not mistaken? |
|
You are correct! If the issues that this surfaces aren't important, then an alternative is to just delete this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #4678, the revive command seems to have had a syntax error in the file input glob. It appears to have been broken in a way that did not result in a return code being set. This change uses 'find' to build the input to the linter.
Note that it is expected to fail the CI script, because it is uncovering some existing lint issues that were not being caught.