fix(rp2): possible integer overflow while computing factors for SPI baudrate #5063
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…audrate Incorrect factors are calculated for baudrates which are a bit larger than integer multiples of 4194304. For example for baudrates of 8_400_000 or 58_800_000. Fixed the same way in newer versions of the RPI SDK.
|
Thank you! This looks like a good idea to me. (There might be more efficient ways of doing this, such as dividing some of these numbers by a power of two to avoid the overflow, but this shouldn't be performance sensitive anyway. Also, 64-bit multiplies are going to be decently fast on the RP2350 with the Cortex-M33). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of integer overflows incorrect factors are calculated for baudrates which are a bit larger than integer multiples of 4194304.
For example for baudrates of 8_400_000 or 58_800_000. Fixed the same way in newer versions of the pico SDK.