Update Executor Contracts #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
etzellux
commented
Feb 8, 2024
|
|
||
| assert(Txn.GroupIndex == 1) | ||
|
|
||
| if Gtxn[0].ApplicationArgs[0] == "validate_transaction": |
There was a problem hiding this comment.
Move this logic to app
There was a problem hiding this comment.
Assert that the Txn.Rekey == Zero Address
etzellux
commented
Feb 8, 2024
| end | ||
|
|
||
| @public() | ||
| func set_fee_setter(proposal_id: bytes, new_fee_setter: bytes): |
There was a problem hiding this comment.
Suggested change
| func set_fee_setter(proposal_id: bytes, new_fee_setter: bytes): | |
| func set_fee_setter(proposal_id: bytes, new_fee_setter: bytes[32]): |
etzellux
commented
Feb 9, 2024
| Fee: 0 | ||
| end | ||
|
|
||
| Proposal proposal = Cast(extract(4, 182, Itxn.LastLog), Proposal) |
There was a problem hiding this comment.
It is better to use Sizeof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update contracts in #3
Compatible sdk version: https://github.com/Hipo/private-tinyman-py-sdk/pull/10/commits/679cdda6b7d12d871c1b66ffc6deebde320de522
Note: This PR also includes changes for
proposal_voting_approvalin #6