TINY-11177: Vastly improve remote testing #145
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it for the report AJAX requests to complete before moving on to the next test.
…d a client-side fix.
…it would be misleading if they were treated as passing.
…th test reports and offsets.
spocke
approved these changes
Aug 16, 2024
|
I posted in slack that this destroys JUnit reporting. Ideas for how to fix: |
…ts. Manual mode works, auto still needs some work.
TheSpyder
force-pushed
the
feature/TINY-11177
branch
from
4feac22
to
e80663d
Compare
…to the end of the test run are now waited for correctly.
…ce for every result
…an empty rejected promise
…her chunks or test retry
… in the catch block
ltrouton
reviewed
Sep 17, 2024
| @@ -139,19 +179,54 @@ export const Reporter = (params: UrlParams, callbacks: Callbacks, ui: ReporterUi | |||
| }; | |||
| }; | |||
|
|
|||
| const waitForResults = async (): Promise<void> => { | |||
| sendCurrentResults(); | |||
| if (requestsInFlight.length > 0) { | |||
There was a problem hiding this comment.
Should we explicitly put a Promise.resolve() in an else block if requestsInFlight is a length of 0?
| sh 'yarn build' | ||
| }, | ||
| testDirs: [ 'modules/sample/src/test/ts/**/pass' ], | ||
| custom: '--config modules/sample/tsconfig.json --customRoutes modules/sample/routes.json --polyfills Promise Symbol' |
There was a problem hiding this comment.
Can we remove the polyfills now since we are running on browsers that support Promise and Symbol?
| requestsInFlight.length = 0; | ||
| return Promise.all(currentRequests).then(() => { | ||
| // if more things have been queued, such as a failing test stack trace, wait for those as well | ||
| waitForResults(); |
There was a problem hiding this comment.
Should we be returning the promise from waitForResults? Although, I think since the function has the async identifier, JavaScript must handle it automagically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-11177
Description of Changes:
/startbefore eachitblock, and then again to/resultsafter eachitblock. It would wait for these requests to finish before continuing./startis now sent at startup and after every 50 tests. This can be made larger if we find it's still too slow./resultsis now only sent for failure and skip, not pass.Promise.all()at the very end to wait for them.bedrockCLI console HUD depended on receiving these status updates, so I had to adjust it to account for the missing reports.favicon.icorequest which probably also slowed things down.keep-aliveheader is now set, instead of using the default 5 seconds which was causing occasional502 Bad Gatewayerrors.Pre-checks:
Tests have been added (if applicable)Before merging: