Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2228: Updates new bundling with js feature, additional copy edits to bundling with es6 vite documentation. #3020

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Dec 5, 2023

Ticket: DOC-2228

Changes:

  • Updates new bundling with js feature, additional copy edits to bundling with es6 vite documentation.
  • add new js imports such as ./plugins/a11ychecker/css/annotations_css.js to various .adoc files.
  • update message for bundling-plugins-that-cant-bundle.adoc
  • remove premium plugin reference in vite bundling editor.js example code snippet to avoid user confusion.

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • Changelog entry added
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • Files removed have been deleted, not just excluded from the build (if applicable)
  • (New product features only) Release Note added

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested a review from a team as a code owner December 5, 2023 07:04
@kemister85 kemister85 requested review from Afraithe and MitchC1999 and removed request for a team December 5, 2023 07:04
@kemister85
Copy link
Contributor Author

kemister85 commented Dec 5, 2023

@spocke @hamza0867 - ive opened this PR early as it requires your assistance to ensure we are accurate with the incoming changes.

  • verify the correct ./plugins/<plugin-name>/<file-name>_css.js
  • we need to verify that the new JS Example 2 added is correct.

removal of example 1 from bundling-plugins.adoc
condensing of css and js to css or bundled css
modules/ROOT/pages/bundling-plugins.adoc Outdated Show resolved Hide resolved
Co-authored-by: Hamza Benkhaldoun <[email protected]>
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit cc12cff into staging/docs-6 Dec 6, 2023
5 checks passed
@kemister85 kemister85 deleted the feature/6.8/DOC-2228 branch December 6, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants