-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2228: Updates new bundling with js
feature, additional
copy edits to bundling with es6 vite documentation.
#3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemister85
requested review from
spocke,
TheSpyder,
hamza0867,
ShiridiGandham and
ltrouton
December 5, 2023 07:04
kemister85
requested review from
Afraithe and
MitchC1999
and removed request for
a team
December 5, 2023 07:04
@spocke @hamza0867 - ive opened this PR early as it requires your assistance to ensure we are accurate with the incoming changes.
|
update bundling-plugins-that-cant-bundle.adoc message.
spocke
reviewed
Dec 5, 2023
modules/ROOT/partials/plugin-files/plugin-file-list-advcode.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/plugin-files/plugin-file-list-tinycomments.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/plugin-files/plugin-file-list-tinycomments.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/plugin-files/plugin-file-list-export.adoc
Outdated
Show resolved
Hide resolved
removal of example 1 from bundling-plugins.adoc condensing of css and js to css or bundled css
hamza0867
approved these changes
Dec 5, 2023
Co-authored-by: Hamza Benkhaldoun <[email protected]>
modules/ROOT/partials/module-loading/bundling-plugin-language-files.adoc
Outdated
Show resolved
Hide resolved
tiny-ben-tran
approved these changes
Dec 5, 2023
ShiridiGandham
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2228
Changes:
js
feature,additional
copy edits to bundling with es6 vite documentation.js
imports such as./plugins/a11ychecker/css/annotations_css.js
to various.adoc
files.bundling-plugins-that-cant-bundle.adoc
premium plugin
reference invite
bundlingeditor.js
example code snippet to avoid user confusion.Pre-checks:
feature/6/
orhotfix/6/
modules/ROOT/nav.adoc
has been updated (if applicable)Review: