Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2230: add new How to fix invalid API key in TinyMCE page to tinymce/docs project. #3026

Merged
merged 2 commits into from
Dec 8, 2023
Merged

DOC-2230: add new How to fix invalid API key in TinyMCE page to tinymce/docs project. #3026

merged 2 commits into from
Dec 8, 2023

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Dec 7, 2023 •
edited
Loading

Ticket: DOC-2230

Changes:

  • add new FAQ tree to tinymce-docs project that contains Invalid API Key page.
  • small typo correction for tinymce 6.8.1 docs

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • Changelog entry added
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • Files removed have been deleted, not just excluded from the build (if applicable)
  • (New product features only) Release Note added

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested a review from a team as a code owner December 7, 2023 01:58
ShiridiGandham
ShiridiGandham approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MitchC1999
MitchC1999 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@MitchC1999 MitchC1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can find a better solution soon

@kemister85 kemister85 merged commit 102fd93 into release/docs-6 Dec 8, 2023
5 checks passed
@kemister85 kemister85 deleted the hotfix/6.8/DOC-2230 branch December 8, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchC1999 MitchC1999 MitchC1999 approved these changes

@ShiridiGandham ShiridiGandham ShiridiGandham approved these changes

@TheSpyder TheSpyder Awaiting requested review from TheSpyder

@Afraithe Afraithe Awaiting requested review from Afraithe Afraithe was automatically assigned from tinymce/documentation-team

@EkimChau EkimChau Awaiting requested review from EkimChau EkimChau was automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kemister85 @ShiridiGandham @MitchC1999