Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2354: Add TINY-10766 release note entry #3199

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

FarzadHayat
Copy link
Contributor

@FarzadHayat FarzadHayat commented Mar 28, 2024

Ticket: DOC-2354
Entry: TINY-10766

Site: Staging branch
7.0 known issue updated with reference: 7.0 Release Notes

Changes:

Pre-checks:

  • Branch prefixed with feature/7/ or hotfix/7/
  • Files added for New product features, and included a release note entry.

Review:

  • Documentation Team Lead has reviewed

@FarzadHayat FarzadHayat added the upcoming release Documentation for features currently under development/QA label Mar 28, 2024
@FarzadHayat FarzadHayat added this to the TinyMCE 7.0.1 milestone Mar 28, 2024
@FarzadHayat FarzadHayat self-assigned this Mar 28, 2024
@FarzadHayat FarzadHayat requested a review from a team as a code owner March 28, 2024 07:07
@FarzadHayat FarzadHayat requested review from Afraithe and ShiridiGandham and removed request for a team, Afraithe and ShiridiGandham March 28, 2024 07:07
==== Pasting markdown into some situations would cause the pasted data to be placed in unexpected places.
// #TINY-10766

Previously in the **Markdown** plugin, the "markdown-on-paste" feature used the `editor.selection.setContent` function to insert content into the {productname} editor. However, this approach resulted in unexpected cursor behavior, undo levels, and formatting issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to show these particular details? While that is what the actual change is, it might be easier to understand if we put it as some sort of "Previous content insertion was not given the expected formatting treatment" or something along those lines?
If we're fine with those details being here though, seems fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these details are suitable, and would suggest merging this as they are personally.

@FarzadHayat
Copy link
Contributor Author

FarzadHayat commented Apr 8, 2024

@kemister85 @HAFRMO release note entry has been rewritten. please review once more. :)
7.0.1 entry updated: 7.0.1 Release Notes
7.0 known issue updated with reference: 7.0 Release Notes

@kemister85
Copy link
Contributor

LGTM, thanks for adding known issue links

@FarzadHayat FarzadHayat merged commit 537a717 into feature/7/DOC-2354 Apr 8, 2024
4 checks passed
@FarzadHayat FarzadHayat deleted the feature/7/DOC-2354_TINY-10766 branch April 8, 2024 08:00
FarzadHayat added a commit that referenced this pull request Apr 10, 2024
* DOC-2354 7.0.1 Release Notes initial outline

* add deprecated to nav.adoc

* update GitHub PR template

* DOC-2354: Add TINY-10789 release note entry (#3191)

* DOC-2354: Add TINY-10789 release note entry

* move TINY-10789 entry to accompanying-premium-plugin-changes section

* DOC-2354: Add TINY-10760 release note entry (#3197)

* DOC-2354: Add TINY-10682 release note entry (#3192)

* DOC-2354: Add TINY-10682 release note entry

* Improve CCFR and add example of before/after fix.

* Added an example to TINY-10789

* Apply suggestions from Shan's code review

Co-authored-by: shanmen-tiny <[email protected]>

* Add live demo examples for TINY-10789

* Add live demo example for TINY-10682

---------

Co-authored-by: shanmen-tiny <[email protected]>

* remove some unnecessary sections

* DOC-2354: Add TINY-10785 release note entry (#3193)

* DOC-2354: Add TINY-10785 release note entry

* Apply suggestions from Karl's code review

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* Update entry heading

Co-authored-by: tiny-ben-tran <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: tiny-ben-tran <[email protected]>

* DOC-2354: Add TINY-10784 release note entry (#3200)

* DOC-2354: Add TINY-10784 release note entry

* Improve release note entry to be more accurate

* DOC-2354: Add TINY-10684 release note entry (#3208)

* DOC-2354: Add TINY-10715 release note entry (#3195)

* DOC-2354: Add TINY-10488 release note entry (#3201)

* DOC-2354: Add TINY-10488 release note entry

* Apply suggestions from Mitch's code review

Co-authored-by: Mitchell Crompton <[email protected]>

---------

Co-authored-by: Mitchell Crompton <[email protected]>

* DOC-2354: Add TINY-10797 release note entry (#3196)

* DOC-2354: Add TINY-10797 release note entry

* Apply suggestions from Karl's code review

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

* DOC-2354: Add TINY-10705 release note entry (#3194)

* DOC-2354: Add TINY-10705 release note entry

* DOC-2354: Add a link

---------

Co-authored-by: Ben Tran <[email protected]>

* DOC-2354: Add TINY-10766 release note entry (#3199)

* DOC-2354: Add TINY-10766 release note entry

* improve paragraphs and add reference back to known issue in 7.0 release notes

* improvement to entry

* add reference back to fix from original 7.0 known issue entry

* DOC-2354: Add TINY-10747 release note entry (#3209)

* DOC-2354: Add TINY-10747 release note entry

* relocate entry to inside markdown heading

* remove unused template code

* fix order of entries to match changelog

* moved TINY-10715 to open source bug fixes section

* fix TINY-10715 entry

* add 7.0.1 changelog entries to changelog.adoc

* Apply suggestions from Karl's code review

Co-authored-by: Karl Kemister-Sheppard <[email protected]>

---------

Co-authored-by: shanmen-tiny <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: tiny-ben-tran <[email protected]>
Co-authored-by: Mitchell Crompton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Documentation for features currently under development/QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants