-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2368: Update bundling documentation for all premium plugins for new index.js files. #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpyder
reviewed
Apr 11, 2024
…partials,includes.
6 tasks
kemister85
added
the
upcoming release
Documentation for features currently under development/QA
label
Apr 15, 2024
… import code blocks.
spocke
approved these changes
Apr 16, 2024
kemister85
requested review from
a team,
TheSpyder,
ltrouton,
tiny-ben-tran,
danoaky-tiny,
lostkeys,
hamza0867,
vpyshnenko and
ztomaszyk
and removed request for
a team
April 18, 2024 01:27
danoaky-tiny
approved these changes
Apr 23, 2024
ltrouton
reviewed
Apr 23, 2024
modules/ROOT/partials/plugin-files/plugin-file-bundling-message.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/plugin-files/plugin-file-bundling-also-requires.adoc
Outdated
Show resolved
Hide resolved
…e.adoc Co-authored-by: ltrouton <[email protected]>
Co-authored-by: ltrouton <[email protected]>
…equires.adoc Co-authored-by: ltrouton <[email protected]>
Co-authored-by: ltrouton <[email protected]>
…n is equal to or less than 7.0.
ltrouton
approved these changes
Apr 24, 2024
Co-authored-by: ltrouton <[email protected]>
ShiridiGandham
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MitchC1999
approved these changes
Apr 24, 2024
kemister85
added a commit
that referenced
this pull request
May 8, 2024
* DOC-2375: TinyMCE 7.1 Documentation. * DOC-2368: Update bundling documentation for all premium plugins for new index.js files. (#3224) * DOC-2368: Update bundling documentation for all premium plugins for new index.js files. * DOC-2368: additional improvements. * DOC-2368: additional copy edits to bundling-plugins.adoc and related partials,includes. * Revert "DOC-2339: On-premises documentation for document converters. (#3180)" This reverts commit 93d7ffe. * DOC-2368: update plugin code ref. * DOC-2368: delete plugin-file-plugins.adoc pages, update plugin.js for import code blocks. * Update modules/ROOT/partials/plugin-files/plugin-file-bundling-message.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/partials/plugin-files/plugin-file-index.js.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/partials/plugin-files/plugin-file-bundling-also-requires.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/pages/bundling-plugins.adoc * Update modules/ROOT/pages/bundling-plugins.adoc Co-authored-by: ltrouton <[email protected]> * DOC-2368: update plugin-file-list-emoticons.adoc file to include note. * DOC-2368: add note to reference back to the tinymce v6 docs if version is equal to or less than 7.0. * Update modules/ROOT/pages/bundling-plugins.adoc Co-authored-by: ltrouton <[email protected]> --------- Co-authored-by: ltrouton <[email protected]> * DOC-288 (#3262) * DOC-2386: add Google Gemini integration guide (#3250) * Add Google Gemini integration guide * Update Gemini string response example to use Vertex AI * Add admonition about access token security above each code example * Fix indentation in code examples * Update admonition from Mitch's suggestions Co-authored-by: Mitchell Crompton <[email protected]> * Improve code example comments about authentication Co-authored-by: Mitchell Crompton <[email protected]> * Remove pronouns from admon-ai-proxy.adoc and ai-gemini.adoc * change order of nav items * Apply suggestions from code review Only include ai proxy admon once per page Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2387: Add live demo to AI Assistant plugin page (#3260) * DOC-2387: Add live demo to AI Assistant plugin page * fix the authorization header in index.js * update live demo content to match website ai demo * add admonition that live demo uses proxy * DOC-2385: add Amazon Bedrock integration guide (#3252) * DOC-2384: Added local playbook and dev scripts (#3247) * Initial draft for Amazon Bedrock integration guide * change order of nav.adoc items * add ai proxy admonition (will be functional once merged into tinymce/7) * Revert "DOC-2384: Added local playbook and dev scripts (#3247)" This reverts commit 8631a51. * Apply suggestions from code review Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2399: Extract OpenAI integration code to separate page (#3270) * add ai-openai.adoc page with OpenAI string and streaming code examples * change ai_request to use minimal string response code example * remove basic setup section from ai.adoc and fix options headings nesting levels * add missing heading to ai-openai.adoc * move openai to above proxy in nav.adoc * add ai proxy admonitions (will be functional once merged into tinymce/7) * only include ai proxy admon once per page * change gemini prerequisites to ordered list * DOC-2381: add new `Math` Plugin documentation for TinyMCE 7.1. (#3253) * DOC-2381: add new Math plugin documentation for TinyMCE 7.1. * Update modules/ROOT/examples/live-demos/math/index.js * DOC-2381: update math demo, and removed examples of using equations. * Update premium-plugins.adoc Co-authored-by: spocke <[email protected]> * Update math.adoc Co-authored-by: spocke <[email protected]> * Update math.adoc Co-authored-by: spocke <[email protected]> * Update math.adoc Co-authored-by: spocke <[email protected]> * Update math.adoc Co-authored-by: spocke <[email protected]> * Update modules/ROOT/pages/math.adoc * DOC-2381: Demo update, and included examples of block vs inline. * DOC-2381: Updated index.html for demo. * Update modules/ROOT/examples/live-demos/math/index.html * Update modules/ROOT/partials/misc/admon-requires-7.1v.adoc Co-authored-by: Farzad Hayat <[email protected]> * add plugin to available-menu-items.adoc * add plugin to available-toolbar-buttons.adoc * add plugin to editor-command-identifiers.adoc * add plugin to full-featured demo * Update modules/ROOT/examples/live-demos/math/index.html Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/partials/menu-item-ids/math-menu-items.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/partials/toolbar-button-ids/math-toolbar-buttons.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/partials/menu-item-ids/math-menu-items.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: ltrouton <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: ltrouton <[email protected]> * Removed details - Update modules/ROOT/pages/math.adoc * Details amended - Update modules/ROOT/pages/math.adoc * Demo content updated - Update modules/ROOT/examples/live-demos/math/index.html * Updated information - Update modules/ROOT/pages/math.adoc * Added list separator -Update modules/ROOT/pages/math.adoc * italicised some text- Update modules/ROOT/pages/math.adoc * Apply suggestions from code review Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Andrew Herron <[email protected]> * Update modules/ROOT/pages/math.adoc Co-authored-by: spocke <[email protected]> --------- Co-authored-by: spocke <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: ltrouton <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Andrew Herron <[email protected]> * DOC-2366: Add revision history diff API (#3278) * DOC-2366: Add revision history API section * DOC-2366: Clean up * Update modules/ROOT/partials/plugin-apis/ai-apis.adoc Co-authored-by: Mitchell Crompton <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> * DOC-2401: Add integration docs for Azure OpenAI (#3273) * DOC-2401: Add integration docs for Azure OpenAI * Fix indentation in code * DOC-2401: Edits to azure ai page * Apply suggestions from code review Co-authored-by: shirqa <[email protected]> Co-authored-by: Mitchell Crompton <[email protected]> * DOC-2401: Fix streaming snippet * Update modules/ROOT/nav.adoc * Update modules/ROOT/pages/ai-azure.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: Farzad Hayatbakhsh <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2363: TinyMCE 7.1 release notes and changelog. (#3243) * DOC-2363: TinyMCE 7.1 release notes and changelog. * DOC-2384: Added local playbook and dev scripts (#3247) * change default http-server address to 'localhost' * DOC-2363: New `index.js` file that includes all plugin resources. (#3246) * DOC-2363: New index.js file that includes all plugin resources. * Update modules/ROOT/pages/7.1-release-notes.adoc * Update modules/ROOT/pages/7.1-release-notes.adoc * DOC-2363: Removed `aria-pressed` from the `More` button in sliding toolbar mode and replaced it with `aria-expanded` (#3267) * DOC-2363: Removed aria-pressed from the More button in sliding toolbar mode and replaced it with aria-expanded. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Shan <[email protected]> --------- Co-authored-by: Shan <[email protected]> * DOC-2363: Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. (#3266) * DOC-2363: Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Shan <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Shan <[email protected]> --------- Co-authored-by: Shan <[email protected]> * DOC-2363: Add TINY-10597 release note entry (#3256) * DOC-2363: Add TINY-10800 release note entry (#3255) * DOC-2363: Dialog title was not announced in macOS VoiceOver, dialogs now use `aria-label` instead of `aria-labelledby` on macOS. (#3271) * DOC-2363: Dialog title was not announced in macOS VoiceOver, dialogs now use aria-label instead of aria-labelledby on macOS. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: ToggleToolbarDrawer command did not toggle the toolbar in sliding mode when {skipFocus: true} parameter was passed. (#3265) * DOC-2363: Firefox not announcing the iframe title when `iframe_aria_text` was set. (#3275) * DOC-2363: Firefox not announcing the iframe title when was set. * Update 7.1-release-notes.adoc Co-authored-by: Shan <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc --------- Co-authored-by: Shan <[email protected]> * DOC-2363: release note entry for TINY-10725 (#3251) * DOC-2363: add changelog for TinyMCE 7.1 core changes. * DOC-2396: add Windows High Contrast mode support to 7.1 release notes (#3279) * DOC-2396: add Windows High Contrast mode support to 7.1 release notes * Apply suggestions from code review Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]> * DOC-2363: Add TINY-10780 release note entry (#3254) * DOC-2363: Included `itemprop`, `itemscope`, `itemtype` as valid HTML5 attributes in the core schema. (#3244) * DOC-2363: Included itemprop, itemscope, itemtype as valid HTML5 attributes in the core schema. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: Accompanying Premium self-hosted server-side component changes in TinyMCE 7.1. (#3274) * DOC-2363: Open link context menu action was not enabled for links on images. (#3277) * DOC-2363: Open link context menu action was not enabled for links on images. * DOC-2363: Add release note for open link context menu action issues * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> --------- Co-authored-by: Ben Tran <[email protected]> Co-authored-by: Mitchell Crompton <[email protected]> * DOC-2363: Notification width was not constrained to the width of the editor. (#3268) * DOC-2363: Notification width was not constrained to the width of the editor. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/changelog.adoc * Update modules/ROOT/pages/changelog.adoc * DOC-2363: Video and audio elements could not be played on Safari. (#3258) * DOC-2363: Video and audio elements could not be played on Safari. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: In the custom view, the scrollbar of the container were not visible if its height was greater than the editor. (#3272) * DOC-2363: In the custom view, the scrollbar of the container were not visible if its height was greater than the editor. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc --------- Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc * Update modules/ROOT/pages/7.1-release-notes.adoc * Update modules/ROOT/pages/7.1-release-notes.adoc * DOC-2363: Styles were not retained when toggling a list on and off. (#3269) Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: Added new `A11ycheckStart`, `A11ycheckStop`, `A11ycheckIgnore`, `A11ycheckRepair` and `A11ycheckShowDetails` events.. (#3245) * DOC-2363: Added new A11ycheckStart, A11ycheckStop, A11ycheckIgnore, A11ycheckRepair and A11ycheckShowDetails events. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/partials/events/a11ychecker-events.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Add Accessibility Checker events to events page * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: Custom block elements with colon characters would throw errors. (#3259) * DOC-2363: Custom block elements with colon characters would throw errors. * DOC-2363: Custom block elements with colon characters would throw errors. * Update modules/ROOT/pages/7.1-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC--2363: Fixed accessibility issue by removing duplicate role (menu) attribute from color swatches. (#3261) Co-authored-by: Farzad Hayat <[email protected]> * DOC-2363: final copy edits and removal of trailing template material. * Update modules/ROOT/pages/7.1-release-notes.adoc * DOC-2363: add revisionhistory_diff_classes entry to the TinyMCE 7.1 release notes. * Update modules/ROOT/pages/7.1-release-notes.adoc --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Farzad Hayatbakhsh <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]> Co-authored-by: Ben Tran <[email protected]> * DOC-2408: update support page EOS dates to include 7.1 entry (#3284) * DOC-2408: update support page EOS dates to include 7.1 entry * Update modules/ROOT/partials/misc/supported-versions.adoc --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> --------- Co-authored-by: ltrouton <[email protected]> Co-authored-by: Shan <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: spocke <[email protected]> Co-authored-by: shirqa <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> Co-authored-by: Andrew Herron <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2368
Site: Staging branch
Changes:
Update
bundling-plugins.adoc to reflect simplified bundling.Update
integrations to fall inline with these changes.Pre-checks:
feature/7/
orhotfix/7/
Review: