-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2565: Update comments with mentions demos to use blue mentions #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchC1999
requested review from
abhinavgandham,
soritaheng,
FarzadHayat,
LewisAtTiny,
kemister85 and
a team
as code owners
November 5, 2024 05:58
kemister85
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing locally, LGTM 👍
ArvinJ-H
approved these changes
Nov 5, 2024
tiny-ben-tran
approved these changes
Nov 5, 2024
shanmen-tiny
approved these changes
Nov 5, 2024
kemister85
added a commit
that referenced
this pull request
Nov 6, 2024
* DOC-2553: TinyMCE 7.5 Release Documentation. * DOC-2558: New comments with mentions page and demos (#3499) * DOC-2558: New comments with mentions page and demos * DOC-2558: Fix codeQL * Apply suggestions from code review Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Apply suggestions from code review Co-authored-by: Karl Kemister-Sheppard <[email protected]> * DOC-2558: Fix some broken mentions * Apply suggestions from code review Co-authored-by: Farzad Hayat <[email protected]> * Apply suggestions from code review Co-authored-by: Farzad Hayat <[email protected]> * Apply suggestions from code review Co-authored-by: Farzad Hayat <[email protected]> * DOC-2558: Revert URL --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> * DOC-2565 (#3502) * DOC-2498: TinyMCE 7.5 Release notes and community changelog. (#3480) * DOC-2498: TinyMCE 7.5 Release notes and community changelog. * DOC-2498: Corrected focus highlight visibility in statusbar path. (#3487) * DOC-2498: The `conversationAuthor` property was missing from create conversation events in the EventLog API. (#3488) * DOC-2498: The conversationAuthor property was missing from create conversation events in the EventLog API. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> * DOC-2498: The toolbar-sticky-offset would still be applied after entering fullscreen mode. (#3481) * DOC-2498: The toolbar-sticky-offset would still be applied after entering fullscreen mode. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2498: Improved color picker aria support. (#3490) * DOC-2498: Improved color picker aria support. * DOC-2498: Add known issue for safari poor announcing aria-labels. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Arvin(Jintao) Han <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Arvin(Jintao) Han <[email protected]> --------- Co-authored-by: Arvin(Jintao) Han <[email protected]> * DOC-2498: Forecolor and backcolor toolbar buttons were not completely greyed out while in readonly mode. (#3486) * DOC-2498: Inability to type { character on German keyboard layouts. (#3491) * DOC-2498: Inability to type { character on German keyboard layouts. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2498: Update TinyMCE for Java Swing contact sales link. (#3497) * DOC-2498: Added new default `li` element styles to the content CSS to prevent child list elements from inheriting certain parent list item styles. (#3495) * DOC-2498: Added new default li element styles to the content CSS to prevent child list elements from inheriting certain parent list item styles. * Update modules/ROOT/pages/7.5-release-notes.adoc * DOC-2498: Default values for tinycomments_author and tinycomments_author_name when empty string provided (#3493) * DOC-2498: Default values for tinycomments_author and tinycomments_author_name when empty string provided * Fix typo * DOC-2498: Removing annotated content, now, removes associated conversation card from the sidebar. (#3498) * DOC-2498: Autocompleter would not activate after applying an inline format like font size in some cases. (#3483) * DOC-2498: The command MarkdownInsert is now registered immediately and operates in an async manner, instead of waiting for resources before registering the command. (#3484) * DOC-2498: Closing a nested modal dialog would lose focus from the editor. (#3482) * DOC-2498: Closing a nested modal dialog would lose focus from the editor. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2498: Improve Document Converter default value for `<pluginname>converter-options` (#3489) * DOC-2498: Added default values for document converter plugins. * DOC-2498: Update default values in plugin.adoc pages. * Update modules/ROOT/partials/configuration/exportpdf.adoc Co-authored-by: Farzad Hayat <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> * DOC-2498: Pasting plain text with the `mceInsertClipboardContent` command is now a synchronous action, to match TinyMCE core behaviour. (#3492) * DOC-2498: Pasting plain text with the mceInsertClipboardContent command is now a synchronous action, to match TinyMCE core behaviour. * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Farzad Hayat <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: tiny-ben-tran <[email protected]> --------- Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> * DOC-2564: Release Note Entry for Mentions in Comments (#3500) * DOC-2564: Release Note Entry for Mentions in Comments * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <[email protected]> * Add backlink for tinycomments_mentions_enabled * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc Co-authored-by: Mitchell Crompton <[email protected]> * Update modules/ROOT/pages/7.5-release-notes.adoc * Update modules/ROOT/pages/7.5-release-notes.adoc --------- Co-authored-by: Karl Kemister-Sheppard <[email protected]> Co-authored-by: Mitchell Crompton <[email protected]> * DOC-2498: Pre release cleanup, removal of template material. * DOC-2498: Added support for using raw CSS in the list of possible colours, using the `color_map_raw` property. (#3501) * DOC-2498: Added support for using raw CSS in the list of possible colours, using the color_map_raw property. * DOC-2598: Add note to thank @andrewnicols for contributing to this feature. * Update modules/ROOT/pages/7.5-release-notes.adoc * Update modules/ROOT/pages/changelog.adoc * Update modules/ROOT/pages/7.5-release-notes.adoc * Update modules/ROOT/pages/7.5-release-notes.adoc * DOC-2498: Copy edits. --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]> --------- Co-authored-by: Mitchell Crompton <[email protected]> Co-authored-by: Farzad Hayat <[email protected]> Co-authored-by: Arvin(Jintao) Han <[email protected]> Co-authored-by: tiny-ben-tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2565
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/
,hotfix/<version>/
,staging/<version>/
, orrelease/<version>/
.Review: