Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2609: Resizing images by typing into the input didn't update the … #3582

Merged
19 changes: 19 additions & 0 deletions modules/ROOT/pages/7.6.1-release-notes.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,25 @@ In {productname} {release-version}, this issue has been resolved by ensuring the

For information on the **Enhanced Table** plugin, see: xref:advtable.adoc[Enhanced Tables].

=== Image Optimizer

The {productname} {release-version} release includes an accompanying release of the **Image Optimizer** premium plugin.

abhinavgandham marked this conversation as resolved.
Show resolved Hide resolved
**Image Optimizer** includes the following fixes.

==== Resizing images by typing into the input didn't update the `style` attribute correctly.
// TINY-11669

An issue was identified where the internal custom `style` attribute of an image was not updated correctly when its width and height were modified via user input.

This occurred because the resize function was triggered while the selection was elsewhere, due to a debounce delay between the input and the resize operation. As a result, the resize operation was performed on the current selection instead of the intended image.

This led to other editor components that rely on the `style` attribute accidentally reading outdated values, and the resize not being applied correctly since the selection was not on the image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, this Jira ended having 2 different issues and probably my description was kinda confusing.

the first problem (the one that interfere with the the other editor component) was that updating the width and height via input we didn't update correctly the data-mce-style so some other element, like some plugin, took a non updated value

the second one was about the timeout.

in the Jira documentation the 2 cases are indicated in each section via numbers 1 or 2 when you read 1. [something] that something is referring to the first case and if there is a 2 is referred to the second case.

If you want we can have a call tomorrow morning, I didn't manage this Jira well and there is a little bit of confusion in that documentation :/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzo-pomili Yeah sure

abhinavgandham marked this conversation as resolved.
Show resolved Hide resolved

{productname} {release-version} resolves this issue by updating the `style` attribute appropriately whenever a resize operation is performed. The resize function now takes in the intended image as a parameter, ensuring that all editor components referencing the `style` attribute read the most recent value entered. Additionally, the resize operation is applied to the correct image, even before the debounce time elapses.
abhinavgandham marked this conversation as resolved.
Show resolved Hide resolved

For information on the **Image Optimizer** plugin, see: xref:uploadcare.adoc[Image Optimizer].

[[accompanying-premium-plugin-end-of-life-announcement]]
== Accompanying Premium plugin end-of-life announcement

Expand Down
Loading