Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2609: Resizing images by typing into the input didn't update the … #3582
DOC-2609: Resizing images by typing into the input didn't update the … #3582
Changes from 5 commits
f6559ec
216ed51
366657f
8663e6d
069f113
b861eaf
4fd4a92
c9a7404
4bbc6f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, this Jira ended having 2 different issues and probably my description was kinda confusing.
the first problem (the one that interfere with the the other editor component) was that updating the width and height via input we didn't update correctly the
data-mce-style
so some other element, like some plugin, took a non updated valuethe second one was about the timeout.
in the Jira documentation the 2 cases are indicated in each section via numbers
1
or2
when you read1. [something]
that something is referring to the first case and if there is a2
is referred to the second case.If you want we can have a call tomorrow morning, I didn't manage this Jira well and there is a little bit of confusion in that documentation :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorenzo-pomili Yeah sure