Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-3308_2: Put back support for any unknown key to be assigned as an init prop #532

Merged
merged 2 commits into from
May 28, 2024
Merged

INT-3308_2: Put back support for any unknown key to be assigned as an init prop #532

merged 2 commits into from
May 28, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented May 27, 2024 •
edited by jira bot
Loading

INT-3308

Changes:

  • This allows unknown init props to be assigned again, as it's needed for props that are added by plugins. These plugin init props aren't typed in the base editor options.
  • Removed the export for EditorOptions, as it wasn't exported before the previous PR.
  • Added a test for this typing behaviour.

@danoaky-tiny danoaky-tiny marked this pull request as ready for review May 27, 2024 01:31
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner May 27, 2024 01:31
@danoaky-tiny danoaky-tiny merged commit f35497d into main May 28, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3308_2 branch May 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinJ-H ArvinJ-H ArvinJ-H approved these changes

@lorenzo-pomili lorenzo-pomili lorenzo-pomili approved these changes

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny

@jscasca jscasca Awaiting requested review from jscasca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danoaky-tiny @lorenzo-pomili @ArvinJ-H