Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-2957: manage attribute id #57

Merged
merged 3 commits into from
Jan 8, 2024
Merged

INT-2957: manage attribute id #57

merged 3 commits into from
Jan 8, 2024

Conversation

lorenzo-pomili
Copy link
Collaborator

INT-2957
issue: #32

@lorenzo-pomili lorenzo-pomili requested a review from a team as a code owner December 19, 2023 08:40
@lorenzo-pomili lorenzo-pomili requested review from spocke, hamza0867, vpyshnenko, a team and HAFRMO and removed request for a team December 19, 2023 08:40
spocke
spocke approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@spocke spocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also have a changelog item?

@lorenzo-pomili
Copy link
Collaborator Author

@spocke I added the changelog entry, have a look at it

spocke
spocke approved these changes Jan 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@lorenzo-pomili lorenzo-pomili merged commit 684c7fa into main Jan 8, 2024
4 checks passed
@lorenzo-pomili lorenzo-pomili deleted the feature/INT-2957 branch January 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke spocke approved these changes

@vpyshnenko vpyshnenko vpyshnenko approved these changes

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@HAFRMO HAFRMO Awaiting requested review from HAFRMO HAFRMO was automatically assigned from tinymce/high-velocity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzo-pomili @spocke @vpyshnenko