Merge pull request #182 from tipisai/improve/message-list

feat: improve message list scroll timing
tipisai · May 7, 2024 · 1bfaa60 · 1bfaa60
2 parents 5294909 + 557d002
commit 1bfaa60
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/apps/agent/src/components/PreviewChat/index.tsx b/apps/agent/src/components/PreviewChat/index.tsx
@@ -31,7 +31,6 @@ export const PreviewChat: FC<PreviewChatProps> = (props) => {
 
   const scrollDirectRef = useRef<SCROLL_DIRECTION>(SCROLL_DIRECTION.DOWN)
   const cacheLastScroll = useRef<number>(0)
-  const cacheMessageLength = useRef(chatMessages.length)
 
   const handleClickStopGenerating = useCallback(() => {
     TipisTrack.track("click_stop_generate")
@@ -58,20 +57,15 @@ export const PreviewChat: FC<PreviewChatProps> = (props) => {
   }
 
   useEffect(() => {
-    if (chatMessages.length === 0) {
-      scrollDirectRef.current = SCROLL_DIRECTION.DOWN
-    }
-    if (scrollDirectRef.current === SCROLL_DIRECTION.DOWN) {
+    if (
+      !!currentRenderMessage &&
+      scrollDirectRef.current === SCROLL_DIRECTION.DOWN
+    ) {
       chatRef.current?.scrollTo({
         top: chatRef.current.scrollHeight,
       })
-    } else {
-      if (cacheMessageLength.current !== chatMessages.length) {
-        scrollDirectRef.current = SCROLL_DIRECTION.DOWN
-      }
     }
-    cacheMessageLength.current = chatMessages.length
-  }, [chatMessages])
+  }, [currentRenderMessage])
 
   return (
     <div css={previewChatContainerStyle}>