style: explain why no checks are made before removing roles

tippfehlr · Mar 10, 2024 · b4d7c6d · b4d7c6d
1 parent 7aee88c
commit b4d7c6d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/modules/bot.ts b/src/modules/bot.ts
@@ -290,6 +290,9 @@ client.on(Events.PresenceUpdate, async (oldMember, newMember) => {
   activeTemporaryRoles.forEach(activeTemporaryRole => {
     if (!tempRoleIDsToBeAdded.has(activeTemporaryRole.roleID)) {
       const role = newMember.guild?.roles.cache.get(activeTemporaryRole.roleID);
+      // this does not check if the user has the role on purpose:
+      // trying to remove it when the user doesn’t have it does nothing
+      // and the local role cache *could* be invalid resulting in roles getting stuck
       if (role) newMember.member?.roles.remove(role);
       prepare(
         'DELETE FROM activeTemporaryRoles WHERE guildID = ? AND userIDHash = ? AND roleID = ?'