jxl-render: SSE2 version of EPF #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneVert
reviewed
Sep 24, 2023
| step_multiplier: f32, | ||
| ) { | ||
| let width = input[0].width(); | ||
| let $width = width as isize; |
There was a problem hiding this comment.
Is it declaring a variable with ident $width, but it's used later as width?
There was a problem hiding this comment.
We have both width and $width; it's macro implementation details. We need the grid width at macro invocation site, but in order to do that, the caller should give it an ident (which is matched by $width:ident).
EugeneVert
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #80
Conformance test
bikehas 3-step EPF and decoding it is now ~2.3x faster.