-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new models for gemini translation #571
Conversation
...ceConfigurationView/QueryService+ConfigurableService/GeminiService+ConfigurableService.swift
Outdated
Show resolved
Hide resolved
...ceConfigurationView/QueryService+ConfigurableService/GeminiService+ConfigurableService.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we can easily enable LLMStreamService to change models quickly cc78117 |
That's nice |
Speaking of built-in ai, I noticed it's using gemini pro 1.5 flash latest. Do we use latest for gemini too? Or do we stick with the stable build? |
Just keep it this way. I noticed that I use |
I'll take a look at these |
Easydict/Swift/Feature/Configuration/Configuration+Defaults.swift
Outdated
Show resolved
Hide resolved
I have improved the code, replace all AI const stored keys with dynamic variables a6dcd5d . This code can be optimized later, as well as removing unused const keys. |
So we need to replace all the strings 😂 |
Note that gemini-1.0-pro model does not support system instruction google-gemini/generative-ai-python#328 So I change system prompt to user prompt for gemini-1.0-pro model, see in 22bf492 and 67a63f1 . |
Got it, thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@Jerry23011 I haven't looked closely at the Gemini API, does it support canceling stream requests? Like this #577 |
I didn't find any, so I submitted an issue google-gemini/generative-ai-swift#178 |
Good, their developers are very proactive, and next, we just need to wait for them to implement this feature 😃 |
closes #559
The settings pane is now finished and working.
I set the default model as gemini-1.5-flash as it has the same quota with 1.0 and offer better performance.
However, I don't know how to realize
query type
and display available models in the query view