[lib] JSON format parsing & representation #292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Nov 13, 2024
| @@ -0,0 +1,243 @@ | |||
| type JsonValue { | |||
| case String(v: string); | |||
| case Number(v: int); // TODO: float | |||
lib/util/Json.v3
Outdated
| } | ||
|
|
||
| def parse_number() -> JsonValue { | ||
| var res = Ints.parseDecimal(source, pc); |
There was a problem hiding this comment.
To do this properly, it should also support floating point numbers. The logic for that is in the NumberParser in aeneas/src/vst/. We should probably extract some of that logic into another utility.
There was a problem hiding this comment.
Do you think the entirety of NumberParser can be moved to a util file under lib/util?
lib/util/Json.v3
Outdated
| def NO_ERR = ParseError(JsonError.None, "", -1); | ||
| def ERR_RET = JsonValue.Null; | ||
|
|
||
| class JsonParser { |
There was a problem hiding this comment.
This should probably use an underlying TextReader, which will keep track of line number information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a lib file for JSON parsing and handling. This was from my language server project, and I thought maybe it could be useful to refractor this out and have it in the stdlib.
This is a draft; I'll add tests for this tomorrow!