Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use locals as this value inside filter functions #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use locals as this value inside filter functions
This little patch changes the value of `this` inside all filter functions to
that of the `locals` object. Currently it seems that `this` is a reference to
the `filters` object. The purpose is to expose additional data to the filter
function without having to pass additional arguments from the template.

This could potentially be a breaking change if users are currently relying on
`this` being a reference to the `filters` object from within their custom
filters. Additional changes could be relatively easily made to make this
configurable.
wankdanker committed Aug 7, 2014
commit 252aef9237552d2290b251679fed7d41f301134e
2 changes: 1 addition & 1 deletion lib/ejs.js
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ function filtered(js) {
, name = parts.shift()
, args = parts.join(':') || '';
if (args) args = ', ' + args;
return 'filters.' + name + '(' + js + args + ')';
return 'filters.' + name + '.call(locals,' + js + args + ')';
});
};