Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inserting Slate-based markers #4

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Added inserting Slate-based markers #4

merged 2 commits into from
Oct 6, 2022

Conversation

tjcouch-sil
Copy link
Owner

Supports block/inline markers as well as "one-word" markers like \v. Needs to wait to be merged after #3

@tjcouch-sil tjcouch-sil marked this pull request as ready for review October 6, 2022 15:11
@tjcouch-sil tjcouch-sil changed the base branch from main to react-boilerplate-setup October 6, 2022 15:15
@tjcouch-sil tjcouch-sil changed the base branch from react-boilerplate-setup to main October 6, 2022 15:15
katherinejensen00
katherinejensen00 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@katherinejensen00 katherinejensen00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I really appreciate all of the comments!

@tjcouch-sil tjcouch-sil merged commit 8b9827a into main Oct 6, 2022
@tjcouch-sil tjcouch-sil deleted the slate-insert-markers branch October 6, 2022 15:22
@tjcouch-sil tjcouch-sil mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katherinejensen00 katherinejensen00 katherinejensen00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjcouch-sil @katherinejensen00