Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write scripture, more supported markers, misc tidying up #8

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Write scripture, more supported markers, misc tidying up #8

merged 8 commits into from
Oct 19, 2022

Conversation

tjcouch-sil
Copy link
Owner

No description provided.

katherinejensen00
katherinejensen00 previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@katherinejensen00 katherinejensen00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice job on the memoization. Also nice job adding all of the approved markers.

@tjcouch-sil tjcouch-sil changed the base branch from main to react-boilerplate-setup October 19, 2022 18:33
@tjcouch-sil tjcouch-sil changed the base branch from react-boilerplate-setup to main October 19, 2022 18:33
@tjcouch-sil tjcouch-sil marked this pull request as ready for review October 19, 2022 18:33
@tjcouch-sil tjcouch-sil merged commit ed223e3 into main Oct 19, 2022
@tjcouch-sil tjcouch-sil deleted the write-scripture branch October 19, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katherinejensen00 katherinejensen00 katherinejensen00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjcouch-sil @katherinejensen00