(feat) add theme choser + twilight theme #1845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick thing: this PR will replace current user's dark mode. They'll need to reapply their theme choice in preferences again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Brief description of rationale
I added a user migration for different themes, which allows for semi-modular addition of other types of themes. Using this system, I added a "twilight" theme, which is 1000% better than the current dark mode.
FUTURE PLANS: We can overhaul how different themes are loaded. For example, instead of having the if statements, it could just load a folder with only a _colors.scss files for an easier time making new themes as well as not loading a million css files.