Skip to content

Commit

Permalink
Allow navigation to particular tab locations when loading page
Browse files Browse the repository at this point in the history
This disables a workaround which caused the initial loading to
always end up at the playback page, even if another path was after
the #. A comment claimed that it was a "workaround for lost
history/back view after browser reload", so this might cause
some problems. The workaround is still there, but commented out.
  • Loading branch information
dreamlayers committed Oct 25, 2024
1 parent ac2d4fd commit 6ccae83
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion www/app/services/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,17 @@
};
});

/* @ngInject */
/* @ ng Inject */
/* This breaks direct navigation to links when the page loads,
* for example causing
* http://127.0.0.1:6680/mobile/index.html#/tracklist
* to go to
* http://127.0.0.1:6680/mobile/index.html#/
* and then end up at
* http://127.0.0.1:6680/mobile/index.html#/playback
* because that is the angular-ui-router otherwise() location.
* I'm leaving this here, but disabled, because I don't know what
* else might break if I disable this.
module.run(function($location, $log) {
// workaround for lost history/back view after browser reload
if ($location.url()) {
Expand All @@ -123,5 +133,6 @@
$location.replace();
}
});
*/

})(angular.module('app.services.router', ['ionic']));

0 comments on commit 6ccae83

Please sign in to comment.