Skip to content

Remove llamafactory and verl resources req and limit #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

Remove llamafactory and verl resources req and limit #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efb992
feature:remove llamafactory&verl cpu&mem resoures
yuehua-s Oct 13, 2025
5cbb253
feature:remove llamafactory&verl cpu&mem resoures
yuehua-s Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions incubator/llama-factory-on-tke/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ resources:
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
limits:
cpu: "40"
memory: 600Gi
# cpu: ""
# memory: ""
nvidia.com/gpu: "1"
requests:
cpu: "20"
memory: 400Gi
# cpu: ""
# memory: ""
Comment on lines +97 to +102
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented CPU and memory resource specifications contain empty strings. Consider removing these empty values or providing placeholder examples like '# cpu: "40"' to maintain clarity about expected format.

Copilot uses AI. Check for mistakes.
nvidia.com/gpu: "1"

# This is to setup the liveness and readiness probes more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
Expand Down
8 changes: 4 additions & 4 deletions incubator/verl-on-tke/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ resources:
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
limits:
cpu: "40"
memory: 600Gi
# cpu: ""
# memory: ""
nvidia.com/gpu: "1"
requests:
cpu: "20"
memory: 400Gi
# cpu: ""
# memory: ""
Comment on lines +100 to +105
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented CPU and memory resource specifications contain empty strings. Consider removing these empty values or providing placeholder examples like '# cpu: "40"' to maintain clarity about expected format.

Copilot uses AI. Check for mistakes.
nvidia.com/gpu: "1"

# This is to setup the liveness and readiness probes more information can be found here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
Expand Down